Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove non-applicable change entries #26663

Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 26, 2024

Description

These change entries are for features that aren't yet enabled. They are behind build flags.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

n/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

These change entries are for features that aren't yet enabled. They are
behind a build flag.
@Gudahtt Gudahtt marked this pull request as ready for review August 26, 2024 17:20
@Gudahtt Gudahtt requested a review from a team as a code owner August 26, 2024 17:20
Copy link
Contributor

@benjisclowder benjisclowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (e5f4f32) to head (621aa4f).

Additional details and impacted files
@@               Coverage Diff                @@
##           Version-v12.1.0   #26663   +/-   ##
================================================
  Coverage            69.80%   69.80%           
================================================
  Files                 1370     1370           
  Lines                48739    48739           
  Branches             13438    13438           
================================================
  Hits                 34019    34019           
  Misses               14720    14720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [621aa4f]
Page Load Metrics (73 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681511012010
domContentLoaded115330126
load50124732010
domInteractive115330126

@Gudahtt Gudahtt merged commit 335c9e4 into Version-v12.1.0 Aug 26, 2024
74 checks passed
@Gudahtt Gudahtt deleted the v12.1.0-remove-non-applicable-change-entries branch August 26, 2024 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants