Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add IOTX icon #26723

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Aug 28, 2024

Description

Adds icons for IoTeX network: https://chainlist.org/chain/4689

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-353

Manual testing steps

  1. Add IoTeX network as custom network
  2. Icon should display in Network List as well as Native token for IoTeX

Screenshots/Recordings

Screenshot 2024-08-28 at 8 38 03 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Aug 28, 2024

@gambinish gambinish marked this pull request as ready for review August 28, 2024 17:31
@gambinish gambinish requested a review from a team as a code owner August 28, 2024 17:31
@metamaskbot
Copy link
Collaborator

Builds ready [17faba3]
Page Load Metrics (1741 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28421211527521250
domContentLoaded15512110172112761
load15622114174112459
domInteractive138936189
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 274 Bytes (0.00%)

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (6b4257b) to head (17faba3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26723   +/-   ##
========================================
  Coverage    70.07%   70.08%           
========================================
  Files         1413     1413           
  Lines        49315    49317    +2     
  Branches     13780    13780           
========================================
+ Hits         34557    34559    +2     
  Misses       14758    14758           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gambinish gambinish merged commit 46bf4e8 into develop Aug 28, 2024
82 checks passed
@gambinish gambinish deleted the fix/mmassets-353_investigate-iotex-logo branch August 28, 2024 18:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 28, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants