-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ show a notification item in the settings page #26843
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ffa2de7
feat: :sparkles: show a notification item in the settings page
matteoscurati 0187de7
Merge branch 'develop' into feat/settings-page-add-notifications
matteoscurati a272aca
Merge branch 'develop' into feat/settings-page-add-notifications
matteoscurati 5d376ee
Merge branch 'develop' into feat/settings-page-add-notifications
matteoscurati 1ca448e
feat: :sparkles: use the right icon
matteoscurati 2911149
Merge branch 'develop' into feat/settings-page-add-notifications
matteoscurati 3118c1d
Merge branch 'develop' into feat/settings-page-add-notifications
matteoscurati 66187ca
feat: :rotating_light: fix lint
matteoscurati e9d0a98
feat: :sparkles: small small refactor
matteoscurati 6690033
feat: :sparkles: link to the previous page if present
matteoscurati 5ea420d
Merge branch 'develop' into feat/settings-page-add-notifications
matteoscurati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edge case, might be fine.
What happens when a user:
Should they be navigated back to google or to the extension?
I don't want this to be a blocker - so lets ticket and tackle this edge-case later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Prithpal-Sooriya good catch! Look at the new implementation :)