Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply padding to Snaps UI root element no matter the type #26850

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Sep 3, 2024

Description

Fixes a problem where padding would not be applied correctly to the first child of the Snaps UI container. We were expecting all root elements to be div. But many different types of components are allowed at the root. Quick fix by applying the padding no matter what type the root element is.

Open in GitHub Codespaces

Screenshots/Recordings

Before

image

After

image

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Sep 3, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner September 3, 2024 08:33
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 3, 2024
Copy link

sonarcloud bot commented Sep 3, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [70f8b8e]
Page Load Metrics (1876 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint162724411882243117
domContentLoaded161824261856237114
load162324431876247119
domInteractive228237168

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (5c5bc87) to head (70f8b8e).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26850   +/-   ##
========================================
  Coverage    70.13%   70.13%           
========================================
  Files         1424     1424           
  Lines        49567    49567           
  Branches     13867    13867           
========================================
  Hits         34759    34759           
  Misses       14808    14808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 74dc3e7 into develop Sep 3, 2024
86 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-snaps-ui-root-padding branch September 3, 2024 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 3, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants