Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cherry-pick): Adding patch on eth-json-rpc-middleware to disable verifyContract field validation for cosmos #27065

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 11, 2024

Cherry-picks #27021 (4ee09fc)

Description

Adding patch on eth-json-rpc-middleware to disable verifyContract field validation for cosmos

Related issues

Fixes: #26980

Manual testing steps

  1. Submit a types signature request with verifyingContract set to cosmos
  2. Ensure that you are able to sign it

Screenshots/Recordings

Screenshot 2024-09-10 at 4 08 00 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Sep 11, 2024
@jpuri jpuri requested a review from a team as a code owner September 11, 2024 15:23
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Sep 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-block-tracker@9.0.3 None 0 64.5 kB lgbot
npm/@metamask/eth-json-rpc-provider@3.0.2 None 0 75.8 kB metamaskbot

🚮 Removed packages: npm/@metamask/eth-block-tracker@11.0.1, npm/@metamask/eth-json-rpc-middleware@14.0.1, npm/@metamask/eth-json-rpc-provider@4.1.3

View full report↗︎

@jpuri jpuri force-pushed the verify_contract_fix branch from 55ecf69 to 9ea3bd3 Compare September 11, 2024 16:03
@metamaskbot
Copy link
Collaborator

Builds ready [9ea3bd3]
Page Load Metrics (1622 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24419871483413198
domContentLoaded13602060160017986
load13782063162218086
domInteractive11151363015

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (Version-v12.2.3@9cdc924). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             Version-v12.2.3   #27065   +/-   ##
==================================================
  Coverage                   ?   70.49%           
==================================================
  Files                      ?     1400           
  Lines                      ?    49687           
  Branches                   ?    13655           
==================================================
  Hits                       ?    35024           
  Misses                     ?    14663           
  Partials                   ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm danjm changed the title cherry-pick: Adding patch on eth-json-rpc-middleware to disable verifyContract field validation for cosmos fix (cherry-pick): Adding patch on eth-json-rpc-middleware to disable verifyContract field validation for cosmos Sep 11, 2024
@danjm danjm merged commit 5eaa9d3 into Version-v12.2.3 Sep 11, 2024
68 checks passed
@danjm danjm deleted the verify_contract_fix branch September 11, 2024 16:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants