Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redesigned Revoke setApprovalForAll confirmation #27111

Merged
merged 16 commits into from
Sep 25, 2024
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 12, 2024

Description

Includes modifiers to the setApprovalForAll screen to express revocation, including a new transaction simulation component. Includes e2e tests.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3005

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screenshot 2024-09-20 at 12 10 15

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 12, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 12, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [9190a6a]
Page Load Metrics (2011 ± 237 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35936721899607291
domContentLoaded141235721982495238
load144635862011494237
domInteractive1898412010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 10.33 KiB (0.14%)
  • common: 572 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [d7e65fa]
Page Load Metrics (1823 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22823101601588283
domContentLoaded147722981794209100
load15432303182320397
domInteractive16164513517
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 10.6 KiB (0.15%)
  • common: 572 Bytes (0.01%)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.02%. Comparing base (7cce0ee) to head (afb5921).

Files with missing lines Patch % Lines
...s/confirmations/components/confirm/title/title.tsx 33.33% 8 Missing ⚠️
...pproval-for-all-info/set-approval-for-all-info.tsx 71.43% 2 Missing ⚠️
...ve-static-simulation/approve-static-simulation.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           pnf/2937   #27111      +/-   ##
============================================
- Coverage     70.03%   70.02%   -0.01%     
============================================
  Files          1445     1446       +1     
  Lines         50188    50211      +23     
  Branches      14048    14057       +9     
============================================
+ Hits          35145    35158      +13     
- Misses        15043    15053      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [afb5921]
Page Load Metrics (1826 ± 136 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21723741583600288
domContentLoaded143723551808282136
load144623601826283136
domInteractive13168463517
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 10.56 KiB (0.15%)
  • common: 572 Bytes (0.01%)

Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
76.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Base automatically changed from pnf/2937 to develop September 24, 2024 09:07
@metamaskbot
Copy link
Collaborator

Builds ready [f0faa44]
Page Load Metrics (1874 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15902183186716178
domContentLoaded15732108183014670
load15912182187416278
domInteractive14181423617
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 5.8 KiB (0.08%)
  • common: 255 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo merged commit 470420f into develop Sep 25, 2024
75 of 76 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3005 branch September 25, 2024 12:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
@metamaskbot metamaskbot added release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants