-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Redesigned Revoke setApprovalForAll confirmation #27111
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
1244155
to
4a0bd3a
Compare
Builds ready [9190a6a]
Page Load Metrics (2011 ± 237 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
70347a3
to
f01b6c0
Compare
9190a6a
to
5eb91dc
Compare
Builds ready [d7e65fa]
Page Load Metrics (1823 ± 97 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pnf/2937 #27111 +/- ##
============================================
- Coverage 70.03% 70.02% -0.01%
============================================
Files 1445 1446 +1
Lines 50188 50211 +23
Branches 14048 14057 +9
============================================
+ Hits 35145 35158 +13
- Misses 15043 15053 +10 ☔ View full report in Codecov by Sentry. |
e51c167
to
afb5921
Compare
Builds ready [afb5921]
Page Load Metrics (1826 ± 136 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...ions/components/confirm/info/approve/approve-static-simulation/approve-static-simulation.tsx
Show resolved
Hide resolved
...oke-set-approval-for-all-static-simulation/revoke-set-approval-for-all-static-simulation.tsx
Outdated
Show resolved
Hide resolved
...oke-set-approval-for-all-static-simulation/revoke-set-approval-for-all-static-simulation.tsx
Outdated
Show resolved
Hide resolved
...onfirmations/components/confirm/info/set-approval-for-all-info/set-approval-for-all-info.tsx
Outdated
Show resolved
Hide resolved
...oke-set-approval-for-all-static-simulation/revoke-set-approval-for-all-static-simulation.tsx
Show resolved
Hide resolved
...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx
Outdated
Show resolved
Hide resolved
718f1bb
to
98ecbbd
Compare
afb5921
to
450b528
Compare
2df262f
to
d3c97af
Compare
0fb073a
to
4e599e5
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
6d267b0
to
717c4ff
Compare
7a19e49
to
143b96f
Compare
Builds ready [f0faa44]
Page Load Metrics (1874 ± 78 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Includes modifiers to the setApprovalForAll screen to express revocation, including a new transaction simulation component. Includes e2e tests.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3005
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist