-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: limit bridge quote request frequency and cancel requests #27237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelae
changed the base branch from
develop
to
mb890-src-and-dest-asset-pickers-backup-0828
September 18, 2024 05:40
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
September 18, 2024 05:50
0d5762d
to
995c4eb
Compare
micaelae
changed the base branch from
mb890-src-and-dest-asset-pickers-backup-0828
to
mb890-src-and-dest-asset-pickers-backup-0927
October 1, 2024 20:12
micaelae
changed the base branch from
mb890-src-and-dest-asset-pickers-backup-0927
to
mb890-src-and-dest-asset-pickers-backup-0828
October 1, 2024 20:13
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
October 9, 2024 16:28
810ecd1
to
f59a8c9
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
micaelae
changed the base branch from
mb890-src-and-dest-asset-pickers-backup-0828
to
mb890-src-and-dest-asset-pickers-backup-0927
October 9, 2024 16:28
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
2 times, most recently
from
October 9, 2024 18:03
7c2f8e0
to
3222e6d
Compare
7 tasks
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
from
October 9, 2024 18:22
3222e6d
to
6506bef
Compare
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
October 9, 2024 18:47
f59a8c9
to
fde8fa9
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
4 times, most recently
from
October 10, 2024 22:06
78bcf71
to
403d594
Compare
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
October 11, 2024 02:15
fde8fa9
to
3243c7b
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
2 times, most recently
from
October 15, 2024 22:23
46529fe
to
fe7840e
Compare
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
October 16, 2024 01:06
3243c7b
to
34753b0
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
from
October 16, 2024 16:07
fe7840e
to
107470c
Compare
Base automatically changed from
mb890-src-and-dest-asset-pickers-backup-0927
to
develop
October 16, 2024 16:50
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
October 16, 2024 18:27
34753b0
to
3703e95
Compare
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
2 times, most recently
from
November 7, 2024 00:24
24cf78d
to
a8d45e0
Compare
Builds ready [a8d45e0]
Page Load Metrics (1871 ± 147 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
changed the title
chore: bridge quote polling cancellation/limiting and state resets
chore: limit bridge quote request frequency and cancel requests
Nov 7, 2024
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
November 9, 2024 00:40
a8d45e0
to
1a77d8b
Compare
infiniteflower
previously approved these changes
Nov 12, 2024
Builds ready [7e32668]
Page Load Metrics (1814 ± 83 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
November 12, 2024 01:05
7e32668
to
4554864
Compare
Builds ready [4554864]
Page Load Metrics (1940 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
infiniteflower
approved these changes
Nov 12, 2024
ejwessel
approved these changes
Nov 12, 2024
metamaskbot
added
the
release-12.8.0
Issue or pull request that will be included in release 12.8.0
label
Nov 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1448
Manual testing steps
srcAmount > balance
Screenshots/Recordings
Before
N/A
After
Screen.Recording.2024-10-21.at.4.39.47.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist