Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (cherry-pick): custom tracing in production builds (#27124) #27265

Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Sep 18, 2024

Description

Cherry pick of #27124 for version 12.3.0.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added team-confirmations Push issues to confirmations team team-tiger Tiger team (for tech debt reduction + performance improvements) labels Sep 18, 2024
@matthewwalsh0 matthewwalsh0 requested review from kumavis and a team as code owners September 18, 2024 22:14
@@ -89,18 +89,15 @@ const scuttlingConfigBase = {
extra: '',
stateHooks: '',
nw: '',
// Sentry Custom Tracing
document: '',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for audit sake that document was already an exception in MV2, this just excludes it in both MV2 and MV3.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (439f7d6) to head (5a31273).
Report is 15 commits behind head on Version-v12.3.0.

Files with missing lines Patch % Lines
shared/lib/trace.ts 75.00% 5 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27265      +/-   ##
===================================================
- Coverage            70.24%   70.12%   -0.12%     
===================================================
  Files                 1426     1431       +5     
  Lines                50239    50396     +157     
  Branches             13954    13981      +27     
===================================================
+ Hits                 35289    35339      +50     
- Misses               14950    15057     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e413384]
Page Load Metrics (1803 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint158627231814241116
domContentLoaded157327111783247119
load158427221803248119
domInteractive137037178

digiwand
digiwand previously approved these changes Sep 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5a31273]
Page Load Metrics (1681 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15532016168210852
domContentLoaded15061975164710852
load15512074168112058
domInteractive137339178

@matthewwalsh0 matthewwalsh0 merged commit 5e6d703 into Version-v12.3.0 Sep 19, 2024
72 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/cherry-pick-custom-tracing-production branch September 19, 2024 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Sep 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.3.0 on PR, as PR was cherry-picked in branch 12.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants