Sj/caip multichain api spec tests ci #27317
Conversation
…ports for caip-25 and caip-27
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| @@ -43,7 +45,7 @@ async function main() { | |||
| disableGanache: true, | |||
| title: 'api-specs coverage', | |||
| }, | |||
| async ({ driver }: { driver: Driver }) => { | |||
| async ({ driver, extensionId }: any) => { | |||
There was a problem hiding this comment.
adding extensionId: string to this type gave an error so put in any for now
| }); | ||
|
|
||
| await htmlReporter.onEnd({} as IOptions, joinedResults); | ||
|
|
There was a problem hiding this comment.
merged the 2 multichain reports into 1 using the HtmlReporter itself
| @@ -110,6 +110,7 @@ class ChromeDriver { | |||
| return { | |||
| driver, | |||
| extensionUrl: `chrome-extension://${extensionId}`, | |||
| extensionId, | |||
There was a problem hiding this comment.
the code already assumed this existed in buildWebDriver
|
| @@ -874,7 +877,7 @@ jobs: | |||
| at: . | |||
| - run: | |||
| name: Build extension for testing | |||
| command: yarn build:test | |||
| command: CHAIN_PERMISSIONS=1 BARAD_DUR=1 yarn build:test | |||
There was a problem hiding this comment.
Do we need the CHAIN_PERMISSIONS=1 flag?
There was a problem hiding this comment.
I kept getting a spinning loader when i didnt have it.
We have to remove these flags from the regular ci build before merging the feature branch anyways.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist