Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snaps): Set proper text color for secondary button #27335

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Sep 23, 2024

Description

This PR fixes the button in snaps footer of type secondary having the wrong text color on hover.

It also fixes a wrong variant if the interface on had one action provided in the footer.
Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. edit the getHideSnapBranding to return true
  2. go to test snap and use the preinstalled example snap

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner September 23, 2024 13:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 23, 2024
hmalik88
hmalik88 previously approved these changes Sep 23, 2024
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the cursor issue too?

@metamaskbot
Copy link
Collaborator

Builds ready [ab0f362]
Page Load Metrics (1697 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint12422211562477229
domContentLoaded15072074165712761
load15272150169715474
domInteractive12132413416
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 52 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [6b3c232]
Page Load Metrics (1845 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25023011699509245
domContentLoaded16462292181617283
load16552300184518388
domInteractive15122422412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 52 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [cd8c5c4]
Page Load Metrics (1772 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27722071708357172
domContentLoaded15612044174711857
load15702087177212359
domInteractive198145199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 52 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GuillaumeRx GuillaumeRx merged commit 1fec98f into develop Sep 27, 2024
76 of 77 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/fix-snap-footer-button branch September 27, 2024 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants