-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snaps): Set proper text color for secondary button #27335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
hmalik88
previously approved these changes
Sep 23, 2024
Mrtenz
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the cursor issue too?
Mrtenz
approved these changes
Sep 24, 2024
Builds ready [ab0f362]
Page Load Metrics (1697 ± 74 ms)
Bundle size diffs
|
GuillaumeRx
force-pushed
the
gr/fix-snap-footer-button
branch
from
September 26, 2024 14:16
ab0f362
to
6b3c232
Compare
Builds ready [6b3c232]
Page Load Metrics (1845 ± 88 ms)
Bundle size diffs
|
GuillaumeRx
force-pushed
the
gr/fix-snap-footer-button
branch
from
September 27, 2024 12:54
6b3c232
to
cd8c5c4
Compare
Quality Gate failedFailed conditions |
hmalik88
approved these changes
Sep 27, 2024
Builds ready [cd8c5c4]
Page Load Metrics (1772 ± 59 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Sep 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the button in snaps footer of type
secondary
having the wrong text color on hover.It also fixes a wrong variant if the interface on had one action provided in the footer.
Related issues
Fixes:
Manual testing steps
getHideSnapBranding
to returntrue
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist