-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snaps): Keep focus on input if interface re-renders #27429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
GuillaumeRx
changed the title
fix(snaps):Keep focus on input if interface re-renders
fix(snaps): Keep focus on input if interface re-renders
Sep 26, 2024
GuillaumeRx
force-pushed
the
gr/keep-input-focus
branch
from
September 27, 2024 12:53
0c4b9b3
to
d667658
Compare
Quality Gate failedFailed conditions |
Builds ready [d667658]
Page Load Metrics (1669 ± 80 ms)
Bundle size diffs
|
FrederikBolding
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🔥
david0xd
approved these changes
Oct 1, 2024
metamaskbot
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Oct 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a reference to the currently focused input in a snap interface and set the focus back to the last focused input if the interface re-renders.
This fixes a problem where it will loose input focus and set it to the last input of the interface if an interface was re-rendered.
Related issues
Fixes: #27424
Manual testing steps
Screenshots/Recordings
Before
2024-09-26-17-30-23.mp4
After
2024-09-26-17-27-26.mp4
Pre-merge author checklist
Pre-merge reviewer checklist