fix: Handle null return value from getMethodData to prevent destructuring error (#27457)

[Gudahtt]

Description

The original code assumes that getMethodData will always return an object with a name property. However, in certain instances, getMethodData can return null. When this happens, destructuring the name property from null causes a runtime error.

To address this issue, the code has been updated to use optional chaining. This ensures that if getMethodData returns null, the destructuring will not occur, and contractMethodName will be set to undefined instead of causing an error.

Related issues

Fixes: #27436

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sentry-io]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/scripts/lib/transaction/metrics.ts

Function	Unhandled Issue
buildEventFragmentProperties	Error: KeyringController - No keyring found. Error info: There are no keyrings ... Event Count: 1.1k Affected Users: 0
buildEventFragmentProperties	TypeError: Cannot destructure property 'name' of '(intermediate value)' as it is null. ... Event Count: 4 Affected Users: 0
buildEventFragmentProperties	Error: KeyringController - No keyring found. Error info: There are no keyrings MetamaskController.getAccountType(app/s... Event Count: 3 Affected Users: 0

---

_{Did you find this useful? React with a 👍 or 👎}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [f9f22a9]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1857 ± 116 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	253	2230	1590	594	285
		domContentLoaded	1392	2184	1823	237	114
		load	1395	2233	1857	241	116
		domInteractive	14	63	36	12	6

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.15%. Comparing base (5f93766) to head (f9f22a9).

Files with missing lines	Patch %	Lines
app/scripts/lib/transaction/metrics.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           Version-v12.3.1   #27462   +/-   ##
================================================
  Coverage            70.15%   70.15%           
================================================
  Files                 1431     1431           
  Lines                50436    50436           
  Branches             13994    13994           
================================================
  Hits                 35380    35380           
  Misses               15056    15056           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.