fix: fix token approval error

[sahar-fehri]

Description

PR to fix error when users approve a token.

Related issues

Fixes:

Manual testing steps

1. Go to uniswap
2. Choose an ERC20 token to swap with; (make sure you did not approve this token or revoke the approval)
3. Click on approve and swap
4. You should not see an error

Screenshots/Recordings

Before

Screen.Recording.2024-10-02.at.23.30.33.mov

After

Screen.Recording.2024-10-02.at.23.25.11.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [4d8e45f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1927 ± 124 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	637	2456	1825	332	159
		domContentLoaded	1650	2654	1891	246	118
		load	1660	2659	1927	258	124
		domInteractive	27	182	57	37	18

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 11 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[pedronfigueiredo]

LGTM. This fixes a bug also fixed by #27573

[sahar-fehri]

Closing because this got merged first #27573