Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable preview token #27809

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Oct 12, 2024

Description

This PR introduces the ability for the user to utilize a preview token generated by Contentful to view unpublished content. The PR is particularly useful for the marketing team, allowing them to test product announcements before they are published.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

  1. Create a draft feature announcement through contentful.
  2. retrieve the preview token from 1password or from marketing team/ @MetaMask/notifications team
  3. view the page chrome-extension://<YOUR-EXTENSION-URL>/home.html?previewToken=000
  4. navigate to the notifications page (you may need to enable notifications).
  5. You should be able to see preview/draft feature announcements.

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications Notifications team label Oct 12, 2024
@matteoscurati matteoscurati changed the title feat: ✨ enable preview token feat: enable preview token Oct 12, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matteoscurati matteoscurati marked this pull request as ready for review October 12, 2024 05:16
@matteoscurati matteoscurati requested review from a team as code owners October 12, 2024 05:16
@metamaskbot
Copy link
Collaborator

Builds ready [4777aa4]
Page Load Metrics (1655 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14752095165812158
domContentLoaded14321936162410048
load14732035165511354
domInteractive21129432412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 84 Bytes (0.00%)
  • common: 5 Bytes (0.00%)

mathieuartu
mathieuartu previously approved these changes Oct 14, 2024
Copy link

sonarcloud bot commented Oct 15, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [5b93f3b]
Page Load Metrics (1709 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15021942172413263
domContentLoaded14941929168212259
load15031942170912560
domInteractive197540178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 84 Bytes (0.00%)
  • common: 5 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [3b45315]
Page Load Metrics (1789 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint152523331795220106
domContentLoaded15182318174520297
load152623401789216104
domInteractive2410750188
backgroundConnect9125453517
firstReactRender47202913316
getState497172311
initialActions01000
loadScripts11181880131518287
setupStore96523189
uiStartup167525492012273131
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 84 Bytes (0.00%)
  • common: 5 Bytes (0.00%)

@matteoscurati matteoscurati added this pull request to the merge queue Oct 23, 2024
@legobeat
Copy link
Contributor

legobeat commented Oct 23, 2024

@matteoscurati

Step 1: knowing the preview token

What is the preview token? How do I make use of this as a non-team-member?

How can I test it locally? Is there a local version of Contentful this can be used with?

Merged via the queue into develop with commit e6f3c67 Oct 23, 2024
76 checks passed
@matteoscurati matteoscurati deleted the feat/handle-contentful-preview-content branch October 23, 2024 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 23, 2024
@Prithpal-Sooriya
Copy link
Contributor

Prithpal-Sooriya commented Oct 23, 2024

@matteoscurati

Step 1: knowing the preview token

What is the preview token? How do I make use of this as a non-team-member?

How can I test it locally? Is there a local version of Contentful this can be used with?

Hey @legobeat,

@matteoscurati can you create a page in 1password to share this to both developers and marketing teams?

I believe we did the same for portfolio, lets either do the same for extension. Or (to make it easier for the marketing team) we can create preview links in Contentful for when the marketing team handle draft feature announcements.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants