Fix/linea bufix 12.5 #27876
Merged
Fix/linea bufix 12.5 #27876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of success (#27810) Linea seems to be taking longer than other chains to process the approve transaction after it is submitted, so the trade transaction is erroring. This PR adds a hacky workaround where we artificially delay if we're on Linea to give the trade transaction more time. In the future, we'd want to avoid this hack, but for now it should increase the swap success rate on Linea. With the delay, the token symbol also wasn't immediately populating on the awaiting swap page, so this PR also updates how it's retrieved. [](https://codespaces.new/MetaMask/metamask-extension/pull/27810?quickstart=1) Fixes: #27804 1. Start a swap on Linea with a token that you have not granted approval for 2. Observe that the swap does not fail https://github.com/user-attachments/assets/57cdc5e5-cea7-48ad-ba13-38820ecc9155 https://github.com/user-attachments/assets/91bbfbf4-8392-41ea-bfe8-d54813758f5c - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
davibroc
approved these changes
Oct 15, 2024
Builds ready [f8a6d68]
Page Load Metrics (1813 ± 36 ms)
|
micaelae
approved these changes
Oct 15, 2024
ejwessel
approved these changes
Oct 15, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/27810?quickstart=1){kind=link}
metamaskbot
added
the
release-12.5.0
|
No release label on PR. Adding release label release-12.5.0 on PR, as PR was added to branch 12.5.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of #27810 into 12.5.0.
Related issues
Fixes: #27804
Manual testing steps
Screenshots/Recordings
Before
375871389-343ab5ee-1bcb-45cb-9d42-c753b80c1fea.mov
After
LineaSwap.mov
Pre-merge author checklist
Pre-merge reviewer checklist