fix: Fall back to token list for the token symbol #28003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
force-pushed
the
pnf/27970
branch
from
ec108b9 to
37a22d4
Compare
Builds ready [37a22d4]
Page Load Metrics (1909 ± 119 ms)
Bundle size diffs
|
matthewwalsh0
approved these changes
Oct 23, 2024
| return { tokenImage }; | ||
| const tokenSymbol = | ||
| selectedToken?.symbol || | ||
| tokenList[transactionMeta?.txParams?.to as string]?.symbol || |
There was a problem hiding this comment.
Minor, worth extracting the to into a contractAddress variable?
| transactionMeta: TransactionMeta, | ||
| selectedToken: SelectedToken, | ||
| ) => { | ||
| const t = useI18nContext(); | ||
|
|
||
| const tokenList = useSelector(getTokenList) as TokenListMap; |
There was a problem hiding this comment.
One for future note but getTokenList is derived from the global network where as I just added a selector to use tokensChainsCache which is multi-chain compatible as it's a map of data per chain.
pedronfigueiredo
force-pushed
the
pnf/27970
branch
from
37a22d4 to
c679deb
Compare
Builds ready [c679deb]
Page Load Metrics (2682 ± 647 ms)
|
vinistevam
approved these changes
Oct 23, 2024
metamaskbot
added
release-12.7.0
|
Missing release label release-12.6.0 on PR. Adding release label release-12.6.0 on PR and removing other release labels(release-12.7.0), as PR was cherry-picked in branch 12.6.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes: #27970
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist