-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump gridplus-sdk to 2.7.1 #28008
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
1d52c82
to
f80a16d
Compare
new author ok |
a57fe94
to
c0d4fba
Compare
@legobeat I was waiting for the tests to pass before providing approval and rerun failed tests. Now the tests have passed, but I see merge conflicts and there is a step failing: |
network access, install script ok |
c0d4fba
to
d146cdf
Compare
d146cdf
to
2d03c1a
Compare
@hjetpoluru Thanks! It looks like it was just GH being confused with the conflict; rebased cleanly locally. |
2d03c1a
to
5965ed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Bump dependency
gridplus-sdk
to latest by lifting pin.Related issues
Resolves
eth-lattice-keyring
from the gridplus team with updated version ofethereumjs/util
#15927Progresses
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist