Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump gridplus-sdk to 2.7.1 #28008

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 22, 2024

Description

Bump dependency gridplus-sdk to latest by lifting pin.

Open in GitHub Codespaces

Related issues

Resolves

Progresses

Manual testing steps

  • Test basic GridPlus Lattic1 HW wallet flow

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 22, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sovpro/delimited-stream@1.1.0 None 0 7.18 kB sovpro
npm/bitwise@2.2.1 None 0 131 kB florianwendelborn
npm/borc@3.0.0 None 0 162 kB achingbrain
npm/gridplus-sdk@2.7.1 environment, network +8 2.05 MB asmiller1989
npm/iso-url@1.2.1 None 0 13.5 kB hugomrdias
npm/json-text-sequence@0.3.0 None 0 7.66 kB hildjj

View full report↗︎

Copy link

socket-security bot commented Oct 22, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/borc@3.0.0, npm/gridplus-sdk@2.7.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat changed the title deps: Bump gridplus-sdk to 2.7.1 chore: Bump gridplus-sdk to 2.7.1 Oct 22, 2024
@legobeat legobeat force-pushed the deps-gridplus-sdk-2 branch 2 times, most recently from 1d52c82 to f80a16d Compare October 22, 2024 22:57
@legobeat legobeat added the needs-qa Label will automate into QA workspace label Oct 22, 2024
@legobeat legobeat marked this pull request as ready for review October 22, 2024 23:14
@legobeat legobeat requested review from a team as code owners October 22, 2024 23:14
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/borc@3.0.0

new author ok

@legobeat legobeat force-pushed the deps-gridplus-sdk-2 branch 3 times, most recently from a57fe94 to c0d4fba Compare October 23, 2024 11:28
@hjetpoluru
Copy link
Contributor

hjetpoluru commented Oct 23, 2024

@legobeat I was waiting for the tests to pass before providing approval and rerun failed tests. Now the tests have passed, but I see merge conflicts and there is a step failing: Socket Security: Pull Request Alerts.

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/gridplus-sdk@2.7.1

network access, install script ok

@legobeat
Copy link
Contributor Author

@hjetpoluru Thanks! It looks like it was just GH being confused with the conflict; rebased cleanly locally.

Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat requested a review from a team October 23, 2024 18:00
@HowardBraham HowardBraham added this pull request to the merge queue Oct 24, 2024
Merged via the queue into MetaMask:develop with commit fa895e5 Oct 24, 2024
84 of 85 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@legobeat legobeat deleted the deps-gridplus-sdk-2 branch October 24, 2024 03:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-hardware dependencies Pull requests that update a dependency file hardware-lattice1 needs-qa Label will automate into QA workspace team-hardware-wallets team-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants