-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust spacing of quote rate in swaps #28016
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -263,7 +263,7 @@ | |||
} | |||
|
|||
&__exchange-rate-display { | |||
color: var(--color-text-alternative); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value was getting overwritten in a child component so I've removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it and work fine now
Builds ready [f7bc3f0]
Page Load Metrics (1856 ± 86 ms)
Bundle size diffs
|
Description
The PR to remove the legacy swaps code inadvertently caused a misalignment of the quote rate. This PR re-aligns it to be where it is expected.
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist