test: [POM] Migrate onboarding infura call privacy e2e tests #28079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…metamask-extension into pom-migrate-onboarding
Removed test files that were migrated to TypeScript: - test/e2e/tests/privacy/basic-functionality.spec.js - test/e2e/tests/privacy/onboarding-privacy.spec.js
…k/metamask-extension into chloe-migrate-onboarding # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…k/metamask-extension into chloe-migrate-onboarding
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
chloeYue
changed the title
chloeYue
changed the title
Builds ready [390d5be]
Page Load Metrics (2066 ± 98 ms)
Bundle size diffs
|
Builds ready [5622dd4]
Page Load Metrics (2100 ± 88 ms)
Bundle size diffs
|
Builds ready [9ffb554]
Page Load Metrics (2018 ± 106 ms)
Bundle size diffs
|
Builds ready [7d7e571]
Page Load Metrics (2094 ± 179 ms)
Bundle size diffs
|
hjetpoluru
reviewed
Oct 25, 2024
| export const importSRPOnboardingFlow = async (driver: Driver) => { | ||
| console.log('start import srp onboarding flow '); | ||
| export const createNewWalletOnboardingFlow = async (driver: Driver) => { | ||
| console.log('start creat new wallet onboarding flow '); |
There was a problem hiding this comment.
minor nit
Suggested change
| console.log('start creat new wallet onboarding flow '); | |
| console.log("Starting the creation of a new wallet onboarding flow"); |
hjetpoluru
reviewed
Oct 25, 2024
| export const completeCreateNewWalletOnboardingFlow = async (driver: Driver) => { | ||
| console.log('start to complete create new wallet onboarding flow '); | ||
| export const importSRPOnboardingFlow = async (driver: Driver) => { | ||
| console.log('start import srp onboarding flow '); |
There was a problem hiding this comment.
minor nit
Suggested change
| console.log('start import srp onboarding flow '); | |
| console.log("Starting the import of SRP onboarding flow"); |
hjetpoluru
reviewed
Oct 25, 2024
| async clickToggleButton(): Promise<void> { | ||
| console.log('Click Toggle Button'); | ||
| async toggleShowTestNetwork(): Promise<void> { | ||
| console.log('Toggle show test network in select network dialog'); |
There was a problem hiding this comment.
thanks for correcting. Nice job
hjetpoluru
reviewed
Oct 25, 2024
| export const switchToNetworkFlow = async ( | ||
| driver: Driver, | ||
| networkName: string, | ||
| toogleShowTestNetwork: boolean = false, |
There was a problem hiding this comment.
minor nit - typo here
Suggested change
| toogleShowTestNetwork: boolean = false, | |
| toggleShowTestNetwork: boolean = false, |
hjetpoluru
reviewed
Oct 25, 2024
| * | ||
| * @param driver | ||
| * @param networkName - The name of the network to switch to. | ||
| * @param toogleShowTestNetwork - A boolean indicating whether to toggle the display of test networks. Defaults to false. |
There was a problem hiding this comment.
minor typo
Suggested change
| * @param toogleShowTestNetwork - A boolean indicating whether to toggle the display of test networks. Defaults to false. | |
| * @param toggleShowTestNetwork - A boolean indicating whether to toggle the display of test networks. Defaults to false. |
hjetpoluru
reviewed
Oct 25, 2024
|
|
||
| const selectNetworkDialog = new SelectNetwork(driver); | ||
| await selectNetworkDialog.check_pageIsLoaded(); | ||
| if (toogleShowTestNetwork) { |
There was a problem hiding this comment.
Suggested change
| if (toogleShowTestNetwork) { | |
| if (toggleShowTestNetwork) { |
hjetpoluru
reviewed
Oct 25, 2024
| @@ -16,4 +36,4 @@ class networkSwitchModalConfirmation { | |||
| } | |||
| } | |||
|
|
|||
| export default networkSwitchModalConfirmation; | |||
| export default NetworkSwitchModalConfirmation; | |||
There was a problem hiding this comment.
Thanks @chloeYue for correcting and adding the page check that I missed.
hjetpoluru
reviewed
Oct 25, 2024
|
|
||
| export const completeCreateNewWalletOnboardingFlow = async (driver: Driver) => { | ||
| console.log('start to complete create new wallet onboarding flow '); |
There was a problem hiding this comment.
Suggested change
| console.log('start to complete create new wallet onboarding flow '); | |
| console.log('Starting to complete the new wallet onboarding flow'); |
|
@chloeYue, Everything is looking good, just some minor typos. Logging has improved a lot which helps when fixing the flaky tests. Great effort! |
hjetpoluru
reviewed
Oct 26, 2024
| await this.driver.clickElement(this.lockMetaMaskButton); | ||
| } | ||
|
|
||
| async openAccountMenu(): Promise<void> { | ||
| await this.driver.clickElement(this.accountMenuButton); | ||
| } | ||
|
|
||
| async openAccountOptionMenu(): Promise<void> { | ||
| console.log('Open account options menu'); | ||
| await this.driver.clickElement(this.accountOptionMenu); |
There was a problem hiding this comment.
accountOptionMenu is slightly confusing as there is also accountMenuButton.The main issue is that the data-testid that was defined is itself incorrectly named, as shown below. Correcting this would be a huge amount of work.
private readonly accountMenuButton = '[data-testid="account-menu-icon"]';
private readonly accountOptionMenu =
'[data-testid="account-options-menu-button"]';
I am thinking that adding toggleThreeDotMenu, openThreeDotMenu, or showThreeDotMenu would be easier, but I leave it to you to decide as you have worked on this more.
hjetpoluru
reviewed
Oct 26, 2024
|
|
||
| // Validate the default network is Localhost 8545 | ||
| await headerNavbar.check_currentSelectedNetwork('Localhost 8545'); | ||
| await new HeaderNavbar(driver).check_currentSelectedNetwork( |
There was a problem hiding this comment.
Could you explain the reason for changing this line? It's currently used only once, but if someone needs it for reference and there are more calls, it could be easily missed. This brings up the question of whether clean code practices are needed. I will leave it to you to decide.
hjetpoluru
reviewed
Oct 26, 2024
| @@ -18,7 +18,7 @@ import SnapSimpleKeyringPage from '../../page-objects/pages/snap-simple-keyring- | |||
| import TestDapp from '../../page-objects/pages/test-dapp'; | |||
|
|
|||
| describe('Snap Account Signatures @no-mmi', function (this: Suite) { | |||
| this.timeout(150000); // This test is very long, so we need an unusually high timeout | |||
| this.timeout(200000); // This test is very long, so we need an unusually high timeout | |||
There was a problem hiding this comment.
Could you explain why this timeout is needed in general? I see that this is a multiple test scenario in a single test, and it being flaky irrespective of the timeout itself. Could we enhance this in another way, or should it be addressed in a separate ticket then incase then this change made not be needed is my thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
openAccountOptionMenumethod to reduce flakinessRelated issues
Fixes: #28080
Manual testing steps
Check code readability, make sure tests pass.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist