-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update storybook to support NFT images #28105
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GO!
Builds ready [ded4c16]
Page Load Metrics (2142 ± 366 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Description
Storybook was not rendering NFT component images. This was because it was not mocking the
state.metamask.openSeaEnabled
selector that is used for handling and rendering NFT images.This updates the
test-data
redux mocks so that we haveopenSeaEnabled
set to true.Related issues
Fixes:
Manual testing steps
Visit these storybooks. Are the NFT images loading?
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist