Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update storybook to support NFT images #28105

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Oct 25, 2024

Description

Storybook was not rendering NFT component images. This was because it was not mocking the state.metamask.openSeaEnabled selector that is used for handling and rendering NFT images.

This updates the test-data redux mocks so that we have openSeaEnabled set to true.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Visit these storybooks. Are the NFT images loading?

Screenshots/Recordings

Before

Screenshot 2024-10-25 at 09 43 35

After

Screenshot 2024-10-25 at 13 50 46

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner October 25, 2024 12:51
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notifications team label Oct 25, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@matteoscurati matteoscurati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO!

@metamaskbot
Copy link
Collaborator

Builds ready [ded4c16]
Page Load Metrics (2142 ± 366 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35053872062851409
domContentLoaded177253472113751360
load177654172142762366
domInteractive18347666732
backgroundConnect8149323215
firstReactRender48121902010
getState56115178
initialActions00000
loadScripts129344781592669321
setupStore1183362713
uiStartup194756332361767368
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Oct 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2024
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Oct 25, 2024
Merged via the queue into develop with commit 91ec3f8 Oct 25, 2024
84 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the fix/storybook-nft-images branch October 25, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-assets team-notifications Notifications team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants