Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show network badge in detected tokens modal #28231

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Oct 31, 2024

Description

Adds the network badge to the listing of tokens detected

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Import an SRP that ERC20s
  2. Click "Import tokens" in the banner
  3. See network icons in the asset badge

Screenshots/Recordings

Before

After

SCR-20241031-ovkc

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner October 31, 2024 21:39
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Oct 31, 2024
@darkwing darkwing force-pushed the detected-token-icons-badge branch from fce1490 to eaef0c5 Compare October 31, 2024 21:42
@metamaskbot
Copy link
Collaborator

Builds ready [6ceeca1]
Page Load Metrics (2099 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29824652014436209
domContentLoaded16942366204118087
load17612543209919493
domInteractive18112552411
backgroundConnect11200554421
firstReactRender643021216330
getState7167373617
initialActions01000
loadScripts12331766148514670
setupStore1495292110
uiStartup191632692379265127
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 281 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [8cb8f18]
Page Load Metrics (2075 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37726241887536257
domContentLoaded17712617205020197
load17802623207520699
domInteractive22116622512
backgroundConnect868232110
firstReactRender521681103115
getState575302311
initialActions01000
loadScripts12382072148818991
setupStore1272262010
uiStartup198928492316209100
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 281 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@darkwing darkwing added this pull request to the merge queue Nov 7, 2024
Merged via the queue into develop with commit 87299be Nov 7, 2024
76 checks passed
@darkwing darkwing deleted the detected-token-icons-badge branch November 7, 2024 05:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants