Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use accounts api for token detection #28254

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 4, 2024

Description

Enables the flag to use accounts api for token detection

Open in GitHub Codespaces

Related issues

Manual testing steps

Onboard a new wallet and verify erc20 tokens are detected. In the background worker, a network request should hit accounts.api.cx.metamask.io

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner November 4, 2024 02:49
Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the title Update metamask-controller.js chore: use accounts api for token detection Nov 4, 2024
@bergeron bergeron added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Nov 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [3828640]
Page Load Metrics (1729 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15572165173414871
domContentLoaded15372066170113465
load15452161172915172
domInteractive21264505124
backgroundConnect792292612
firstReactRender4511184199
getState44917168
initialActions01000
loadScripts10791563123912057
setupStore106619157
uiStartup17352370192317383
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 39 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bergeron bergeron added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@bergeron bergeron added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
@bergeron bergeron added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit 9d77985 Nov 4, 2024
79 checks passed
@bergeron bergeron deleted the brian/use-accounts-api-for-token-detection2 branch November 4, 2024 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants