test: MMQA-188: remove mmi e2e tests from ci #29233

racitores · 2024-12-16T14:03:50Z

Description

MMI e2e tests are not longer maintained so they need to be removed from ci:

Remove CI (only this in this PR due to the urgency of the change)

Create a new PR to remove the next points:

Remove Docs
node dependencies
Remove e2e/tests
Remove e2e/tests/playwright
Remove references in scripts
Remove stuff not in the code base like https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/116332/workflows/e18a49f4-f111-4728-abc8-23d46b93feb6/jobs/4357634

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-16T14:04:04Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

chloeYue

LGTM

danjm

The "Publish MMI release to Sentry" step of the job-publish-release job also needs to be removed

metamaskbot · 2025-01-15T09:15:06Z

Builds ready [bd7b305]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1578 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1379	1719	1582	89	43
		domContentLoaded	1367	1706	1561	89	43
		load	1381	1728	1578	90	43
		domInteractive	22	134	35	25	12
		backgroundConnect	6	47	16	11	5
		firstReactRender	16	100	57	30	15
		getState	5	67	24	23	11
		initialActions	0	0	0	0	0
		loadScripts	1000	1292	1163	74	35
		setupStore	6	43	10	8	4
		uiStartup	1550	2465	1930	260	125

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-15T09:15:13Z

Builds ready [bd7b305]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1578 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1379	1719	1582	89	43
		domContentLoaded	1367	1706	1561	89	43
		load	1381	1728	1578	90	43
		domInteractive	22	134	35	25	12
		backgroundConnect	6	47	16	11	5
		firstReactRender	16	100	57	30	15
		getState	5	67	24	23	11
		initialActions	0	0	0	0	0
		loadScripts	1000	1292	1163	74	35
		setupStore	6	43	10	8	4
		uiStartup	1550	2465	1930	260	125

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-15T10:23:02Z

Builds ready [2344205]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1780 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1569	2185	1791	170	81
		domContentLoaded	1518	2079	1754	147	71
		load	1567	2103	1780	153	74
		domInteractive	26	185	58	40	19
		backgroundConnect	6	104	25	23	11
		firstReactRender	15	105	45	28	13
		getState	5	87	25	25	12
		initialActions	0	1	0	0	0
		loadScripts	1112	1545	1318	124	59
		setupStore	6	87	19	23	11
		uiStartup	1770	3046	2113	333	160

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

dbrans

LGTM

Gudahtt

LGTM!

metamaskbot · 2025-01-15T14:26:47Z

Builds ready [7d0fa6e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1648 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	331	1896	1591	310	149
		domContentLoaded	1422	1837	1624	111	53
		load	1463	1881	1648	116	56
		domInteractive	25	133	46	28	13
		backgroundConnect	6	58	24	19	9
		firstReactRender	16	101	54	28	14
		getState	4	12	7	2	1
		initialActions	0	1	0	0	0
		loadScripts	1008	1443	1202	107	51
		setupStore	6	88	11	18	8
		uiStartup	1658	2293	1954	192	92

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

racitores changed the title ~~chore: remove mmi e2e tests from ci~~ MMQA-188: remove mmi e2e tests from ci Dec 16, 2024

chloeYue changed the title ~~MMQA-188: remove mmi e2e tests from ci~~ test: MMQA-188: remove mmi e2e tests from ci Dec 16, 2024

chloeYue added e2e-test End to end test for the MetaMask extension team-mmi PRs from the MMI team team-qa QA team and removed team-mmi PRs from the MMI team labels Dec 16, 2024

chloeYue previously approved these changes Dec 16, 2024

View reviewed changes

cmd-ob previously approved these changes Dec 16, 2024

View reviewed changes

danjm requested changes Jan 15, 2025

View reviewed changes

racitores closed this Jan 15, 2025

racitores force-pushed the fix/remove-mmi-e2e-tests branch from ec592df to d8ce2c7 Compare January 15, 2025 08:34

github-actions bot locked and limited conversation to collaborators Jan 15, 2025

ci: remove mmi from pipeline

bd7b305

racitores reopened this Jan 15, 2025

racitores dismissed stale reviews from cmd-ob and chloeYue via bd7b305 January 15, 2025 08:38

racitores marked this pull request as ready for review January 15, 2025 09:05

racitores requested a review from a team as a code owner January 15, 2025 09:05

ci: remove mmi release reference

2344205

dbrans approved these changes Jan 15, 2025

View reviewed changes

Gudahtt approved these changes Jan 15, 2025

View reviewed changes

Merge branch 'main' into fix/remove-mmi-e2e-tests

7d0fa6e

racitores enabled auto-merge January 15, 2025 13:51

danjm approved these changes Jan 15, 2025

View reviewed changes

racitores added this pull request to the merge queue Jan 15, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025

racitores added this pull request to the merge queue Jan 15, 2025

Merged via the queue into main with commit 7a78bf2 Jan 15, 2025
72 checks passed

racitores deleted the fix/remove-mmi-e2e-tests branch January 15, 2025 15:59

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: MMQA-188: remove mmi e2e tests from ci #29233

test: MMQA-188: remove mmi e2e tests from ci #29233

racitores commented Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 16, 2024

chloeYue left a comment

danjm left a comment

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

dbrans left a comment

Gudahtt left a comment

metamaskbot commented Jan 15, 2025

test: MMQA-188: remove mmi e2e tests from ci #29233

test: MMQA-188: remove mmi e2e tests from ci #29233

Conversation

racitores commented Dec 16, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 16, 2024

chloeYue left a comment

Choose a reason for hiding this comment

danjm left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

dbrans left a comment

Choose a reason for hiding this comment

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 15, 2025

racitores commented Dec 16, 2024 •

edited

Loading