Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where reset account would not work. #4523

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Conversation

danfinlay
Copy link
Contributor

Fixes #4462

Ensures that resetAccount() can work on non-stock providers.

I'm unclear how this was ever working, this code hasn't moved in months,
but users report it recently breaking. Maybe we only recently pushed it
to prod.

Fixes #4462

Ensures that resetAccount() can work on non-stock providers.

I'm unclear how this was ever working, this code hasn't moved in months,
but users report it recently breaking. Maybe we only recently pushed it
to prod.
@metamaskbot
Copy link
Collaborator

Builds ready [c53c5d5]: mascara, chrome, firefox, edge, opera

Copy link
Contributor

@bitpshr bitpshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Yeah, this couldn't have been working before...

@danfinlay danfinlay merged commit c0d2dab into develop Jun 7, 2018
@danfinlay danfinlay deleted the i4462-FixResetBug branch June 7, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants