Add old UI component to suggest new UI #4888
Merged
+861
−591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whymarrh Here are some e2e test fixes: https://github.com/MetaMask/metamask-extension/tree/suggest-new-ui-e2e-fixes (I couldn't make PR against this branch because it is from your fork) |
whymarrh
force-pushed
the
suggest-new-ui
branch
4 times, most recently
from
a556ebb to
7eb4535
Compare
danjm
previously approved these changes
Jul 28, 2018
|
Approved. +5 points for the commit messages towards the end. +50 points for describing the futility of one of the commits in the commit message. |
alextsg
reviewed
Jul 28, 2018
old-ui/app/account-qr.js
Outdated
|
|
||
| renderMultiMessage = () => { | ||
| const {Qr} = this.props | ||
| return Qr.message.map((message) => h('.qr-message', message)) |
There was a problem hiding this comment.
Does this need a key prop?
There was a problem hiding this comment.
This lead me to discover that this isn't ever hit in the old UI as showQrView is only ever dispatched with the identity from state.
$ git grep showQrViewold-ui/app/components/account-dropdowns.js:205: actions.showQrView(selected, identity ? identity.name : '')
old-ui/app/components/account-dropdowns.js:314: showQrView: (selected, identity) => dispatch(actions.showQrView(selected, identity)),
So I'll remove this branch.
There was a problem hiding this comment.
But yes, it should've had a key prop for consistency sake
The old QR screen was absolutely positioning everything which broke when the app bar resized for the new UI announcement. This change, while futile*, makes the QR screen less bad. * futile because the old UI is being deprecated
…lection screen addition).
When a user has opted-in to the new UI from the announcement, we don't need an additional notification letting the user know that they've switched.
alextsg
approved these changes
Jul 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4811
Resolves #4896
This PR adds components to the old UI to suggest users try the new UI. There are two new components here, as per @cjeria's design in #4811:
(The commits in this PR add the components in some order, feel free to read commit-by-commit.)
Screenshots of the new flow
I rewrote the old UI's QR screen to not use absolute positioning, it looks the same
I also removed the "in development" banner from atop the on-boarding flow of the new UI.
Remaining tasks:
Move strings out for translations?The old UI isn't localized