[DO NOT MERGE] Add very simple subscription support #5450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While MetaMask never officially supported subscriptions, we added a subscription subprovider to our provider-engine, which people began building on. We have since moved to json-rpc-engine, which lacks this subprovider. We thought this would be fine, since we never officially supported it, but apparently even Drizzle was building its UI framework on this API expectation, so we decided breaking was unacceptable. Rather than completely engineer a new subscription subprovider for json-rpc-engine, or add websocket support (yet), I came up with a very simple way of integrating our old support into the new inpage-provider. Should have the added benefit of automatic memory management, potentially solving memory leaks related to the old subscription support. Likely fixes #5425, pushing as a PR so we can provide the build to those affected devs and see if this fixes their issue.
This was referenced Oct 7, 2018
|
Hopefully replaced by the more comprehensive & thorough #5458. |
Merged
|
@danfinlay should we close this now that #5458 is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posted to validate fix, do not merge until affected dev confirms.
While MetaMask never officially supported subscriptions, we added a
subscription subprovider to our provider-engine, which people began
building on.
We have since moved to json-rpc-engine, which lacks this subprovider. We
thought this would be fine, since we never officially supported it, but
apparently even Drizzle was building its UI framework on this API
expectation, so we decided breaking was unacceptable.
Rather than completely engineer a new subscription subprovider for
json-rpc-engine, or add websocket support (yet), I came up with a very
simple way of integrating our old support into the new inpage-provider.
Should have the added benefit of automatic memory management,
potentially solving memory leaks related to the old subscription
support.
Likely fixes #5425, pushing as a PR so we can provide the build to those
affected devs and see if this fixes their issue.
Relevant code changes visible here in metamask-inpage-provider.
I did my own validation & bug reproduction using this test repo that I composed based on this comment.