Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Token Symbol length to twelve #5816

Merged
merged 1 commit into from
Nov 24, 2018
Merged

Increase Token Symbol length to twelve #5816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/_locales/cs/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,8 +828,8 @@
"supportCenter": {
"message": "Navštivte naše centrum podpory"
},
"symbolBetweenZeroTen": {
"message": "Symbol musí být mezi 0 a 10 znaky."
"symbolBetweenZeroTwelve": {
"message": "Symbol musí být mezi 0 a 12 znaky."
},
"takesTooLong": {
"message": "Trvá to dlouho?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/de/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,8 +807,8 @@
"supportCenter": {
"message": "Gehe zu unserem Support Center"
},
"symbolBetweenZeroTen": {
"message": "Das Symbol muss zwischen 0 und 10 Zeichen haben."
"symbolBetweenZeroTwelve": {
"message": "Das Symbol muss zwischen 0 und 12 Zeichen haben."
},
"takesTooLong": {
"message": "Dauert es zu lang?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,8 +1165,8 @@
"supportCenter": {
"message": "Visit our Support Center"
},
"symbolBetweenZeroTen": {
"message": "Symbol must be between 0 and 10 characters."
"symbolBetweenZeroTwelve": {
"message": "Symbol must be between 0 and 12 characters."
},
"takesTooLong": {
"message": "Taking too long?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/es/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,8 +804,8 @@
"supportCenter": {
"message": "Visita nuestro centro de atención"
},
"symbolBetweenZeroTen": {
"message": "Símbolo debe ser entre 0 y 10 caracteres"
"symbolBetweenZeroTwelve": {
"message": "Símbolo debe ser entre 0 y 12 caracteres"
},
"takesTooLong": {
"message": "¿Está tardando demasiado?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/fr/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,8 +1120,8 @@
"supportCenter": {
"message": "Visitez notre centre d'aide"
},
"symbolBetweenZeroTen": {
"message": "Le symbol doit avoir entre 0 et 10 caractères."
"symbolBetweenZeroTwelve": {
"message": "Le symbol doit avoir entre 0 et 12 caractères."
},
"takesTooLong": {
"message": "Cela prend trop de temps ?"
Expand Down
8 changes: 4 additions & 4 deletions app/_locales/hn/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
},
"decimal": {
"message": "दशमलव परिशुद्धता"
},
},
"defaultNetwork": {
"message": "ईथर लेनदेन के लिए डिफ़ॉल्ट नेटवर्क मुख्य नेट है।"
},
Expand Down Expand Up @@ -741,8 +741,8 @@
"supportCenter": {
"message": "हमारे सहायता केंद्र पर जाएं"
},
"symbolBetweenZeroTen": {
"message": "प्रतीक 0 और 10 अक्षरों के बीच होना चाहिए"
"symbolBetweenZeroTwelve": {
"message": "प्रतीक 0 और 12 अक्षरों के बीच होना चाहिए"
},
"takesTooLong": {
"message": "बहुत समय ले रहा है?"
Expand Down Expand Up @@ -845,7 +845,7 @@
},
"visitWebSite": {
"message": "हमारी वेब साइट पर जाएं"
},
},
"warning": {
"message": "चेतावनी"
},
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/ht/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,8 +1141,8 @@
"supportCenter": {
"message": "Vizite Sant Sipò Nou"
},
"symbolBetweenZeroTen": {
"message": "Senbòl yo dwe ant 0 ak 10 karaktè."
"symbolBetweenZeroTwelve": {
"message": "Senbòl yo dwe ant 0 ak 12 karaktè."
},
"takesTooLong": {
"message": "Pran twò lontan?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/it/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,8 +1123,8 @@
"supportCenter": {
"message": "Visita il nostro Centro di Supporto"
},
"symbolBetweenZeroTen": {
"message": "Il simbolo deve essere lungo tra 0 e 10 caratteri."
"symbolBetweenZeroTwelve": {
"message": "Il simbolo deve essere lungo tra 0 e 12 caratteri."
},
"takesTooLong": {
"message": "Ci sta mettendo troppo?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/ko/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,8 +1114,8 @@
"supportCenter": {
"message": "지원 센터에 방문하기"
},
"symbolBetweenZeroTen": {
"message": "심볼은 0에서 10개 사이의 문자여야 합니다."
"symbolBetweenZeroTwelve": {
"message": "심볼은 0에서 12개 사이의 문자여야 합니다."
},
"takesTooLong": {
"message": "너무 오래 걸리나요?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/nl/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,8 +741,8 @@
"supportCenter": {
"message": "Bezoek ons ​​ondersteuningscentrum"
},
"symbolBetweenZeroTen": {
"message": "Het symbool moet tussen 0 en 10 tekens lang zijn."
"symbolBetweenZeroTwelve": {
"message": "Het symbool moet tussen 0 en 12 tekens lang zijn."
},
"takesTooLong": {
"message": "Duurt te lang?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/pl/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,8 +1042,8 @@
"supportCenter": {
"message": "Odwiedź nasze Centrum Pomocy"
},
"symbolBetweenZeroTen": {
"message": "Symbol musi mieć od 0 do 10 znaków."
"symbolBetweenZeroTwelve": {
"message": "Symbol musi mieć od 0 do 12 znaków."
},
"takesTooLong": {
"message": "Trwa zbyt długo?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/pt/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,8 +741,8 @@
"supportCenter": {
"message": "Visitar o nosso Centro de Suporte"
},
"symbolBetweenZeroTen": {
"message": "Símbolo deve conter entre 0 e 10 characters."
"symbolBetweenZeroTwelve": {
"message": "Símbolo deve conter entre 0 e 12 characters."
},
"takesTooLong": {
"message": "A demorar muito?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/ru/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,8 +816,8 @@
"supportCenter": {
"message": "Перейти в наш Центр поддержки"
},
"symbolBetweenZeroTen": {
"message": "Символ должен быть от 0 до 10 символов."
"symbolBetweenZeroTwelve": {
"message": "Символ должен быть от 0 до 12 символов."
},
"takesTooLong": {
"message": "Слишком долго?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/sk/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,8 +828,8 @@
"supportCenter": {
"message": "Navštivte naše centrum podpory"
},
"symbolBetweenZeroTen": {
"message": "Symbol musí být mezi 0 a 10 znaky."
"symbolBetweenZeroTwelve": {
"message": "Symbol musí být mezi 0 a 12 znaky."
},
"takesTooLong": {
"message": "Trvá to dlouho?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/sl/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,8 +1159,8 @@
"supportCenter": {
"message": "Obiščite naše središče za podporo"
},
"symbolBetweenZeroTen": {
"message": "Simbol mora imeti med 0 in 10 znakov."
"symbolBetweenZeroTwelve": {
"message": "Simbol mora imeti med 0 in 12 znakov."
},
"takesTooLong": {
"message": "Trava predolgo?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/th/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,8 +741,8 @@
"supportCenter": {
"message": "ไปที่ศูนย์สนับสนุนของเรา"
},
"symbolBetweenZeroTen": {
"message": "สัญลักษณ์ต้องมีความยาวตั้งแต่ 0 ถึง 10 อักขระ"
"symbolBetweenZeroTwelve": {
"message": "สัญลักษณ์ต้องมีความยาวตั้งแต่ 0 ถึง 12 อักขระ"
},
"takesTooLong": {
"message": "ใช้เวลานานเกินไปใช่หรือไม่?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/tml/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,8 +828,8 @@
"supportCenter": {
"message": "எங்கள் ஆதரவு மையத்தைப் பார்வையிடவும்"
},
"symbolBetweenZeroTen": {
"message": "குறியீடு 0 மற்றும் 10 எழுத்துகளுக்கு இடையில் இருக்க வேண்டும்."
"symbolBetweenZeroTwelve": {
"message": "குறியீடு 0 மற்றும் 12 எழுத்துகளுக்கு இடையில் இருக்க வேண்டும்."
},
"takesTooLong": {
"message": "நீண்ட நேரம் எடுத்துக்கொள்கிறது?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/tr/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,8 +828,8 @@
"supportCenter": {
"message": "Destek merkezimizi ziyaret edin"
},
"symbolBetweenZeroTen": {
"message": "Sembol 0 ve 10 karakter aralığında olmalıdır."
"symbolBetweenZeroTwelve": {
"message": "Sembol 0 ve 12 karakter aralığında olmalıdır."
},
"takesTooLong": {
"message": "Çok mu uzun sürüyor?"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/zh_CN/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,8 +864,8 @@
"supportCenter": {
"message": "访问我们的支持中心"
},
"symbolBetweenZeroTen": {
"message": "符号应该有0-10个字符."
"symbolBetweenZeroTwelve": {
"message": "符号应该有0-12个字符."
},
"takesTooLong": {
"message": "花费太长时间？"
Expand Down
4 changes: 2 additions & 2 deletions app/_locales/zh_TW/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,8 +822,8 @@
"supportCenter": {
"message": "造訪我們的協助中心"
},
"symbolBetweenZeroTen": {
"message": "代號必須介於 0 到 10 字元間."
"symbolBetweenZeroTwelve": {
"message": "代號必須介於 0 到 12 字元間."
},
"takesTooLong": {
"message": "花費太長時間？"
Expand Down
4 changes: 2 additions & 2 deletions ui/app/components/pages/add-token/add-token.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ class AddToken extends Component {
const symbolLength = customSymbol.length
let customSymbolError = null

if (symbolLength <= 0 || symbolLength >= 10) {
customSymbolError = this.context.t('symbolBetweenZeroTen')
if (symbolLength <= 0 || symbolLength >= 12) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have been a smaller PR to just change the >= to > but increasing just to be safe.

customSymbolError = this.context.t('symbolBetweenZeroTwelve')
}

this.setState({ customSymbol, customSymbolError })
Expand Down