Fix token USD price calculation #5965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix drizzle tests
… fix-etherscan-link-notifications
Fix etherscan links on notifications
Fix notifications link
fix typo in phishing.html title
Add scrolling button to account list
Version 5.3.0 RC1
Changing "Connection" by "Connexion"
Fixed a word french translation (several occurrences of connection instead of connexion)
When MetaMask user calls non-standard ERC20 methods such as `mint`, `tokenData` will be `undefined` and an uncaught error will break the UI
This reverts commit 938f428.
Harden Drizzle test runner script
Should help SEO on the chrome store.
Refine app description
|
@svitekpavel Thanks for the contribution, our develop branch CI tests have been fix. Please rebase your fix branch and we'll get it merged in. |
|
I rebased it. Fixed lint and unit tests. Some unit test in "Transaction Controller" are failing though. |
tmashuang
previously approved these changes
Jan 9, 2019
|
@svitekpavel could you pull I got the test passing too btw. |
|
Closing in favor of #6005, which just cleans this up a bit. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USD price calculation was wrong, see discussion #5960
Please test the fix before merging.
Closes #5960