Add togglable advanced gas controls on send and confirm screens #6112
Conversation
|
I still need to update tests, but code should be good to review |
|
@danjm Can you add more padding above the "advanced options" button link? Like 16px. It's so tight up against the controls above it and could use more breathing room. |
| @@ -0,0 +1,147 @@ | |||
| import React, { Component } from 'react' | |||
There was a problem hiding this comment.
Note that this code is somewhat of a subset of code already in metamask-extension/ui/app/components/gas-customization/gas-modal-page-container/advanced-tab-content/advanced-tab-content.component.js
I will probably remove corresponding code from that component in a future task
| constructor (props) { | ||
| super(props) | ||
|
|
||
| this.debouncedGasLimitReset = debounce((dVal) => { |
There was a problem hiding this comment.
Can we move these properties out of the constructor and use the property syntax? (And then even remove the empty constructor.)
|
user experience when confirming from a dapp:
|
|
@cjeria How does this look re: advanced options button?
|
|
@danjm Can you move it down like 10px-16px more? Sry, super nitpic i know |
danjm
force-pushed
the
i5931-inline-advanced-gas-inputs
branch
from
0112680 to
938f9f9
Compare
|
Great! thx @danjm |
Fixes #5931
Demo:
cc @whymarrh @cjeria