Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump trezor-connect to v7 #6224

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Bump trezor-connect to v7 #6224

merged 1 commit into from
Mar 4, 2019

Conversation

brunobar79
Copy link
Contributor

Trezor asked us to upgrade to the latest version of their library trezor-connect via MetaMask/eth-trezor-keyring#13

I've published a new version of eth-trezor-keyring to npm and QA'ed myself in Chrome & Firefox

@brunobar79 brunobar79 requested review from whymarrh and tmashuang March 1, 2019 23:11
@metamaskbot
Copy link
Collaborator

Builds ready [d77c7d7]: mascara, chrome, firefox, edge, opera

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it seems the only API change was the addition of the required Trezor.manifest call

@danfinlay danfinlay merged commit 8271398 into develop Mar 4, 2019
@danfinlay danfinlay deleted the upgrade-trezor-connect-v7 branch March 4, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants