-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add goerli support #6459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small nitpick: can we drop the changes to the package-lock.json
file as there are no changes to the package.json
file in this PR?
Thanks @whymarrh, good catch. Updated. |
@tmashuang would you be able to give this a QA pass as well? It seems good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to add the network list to the the buyEth
deposit modal
const isTestNetwork = ['3', '4', '42'].find(n => n === network) |
and provide a url for the test network
function getBuyEthUrl ({ network, amount, address, service }) { |
I recommend https://bridge.goerli.com/ from
https://github.com/goerli/testnet/blob/master/README.md#meta-data-görli but requires eth from other test networks, could use the other ones recommended.
Edit: Couldn't get the bridge to work.
https://goerli-faucet.slock.it/ provides 0.05/tx
https://faucet.goerli.mudit.blog/ will need a social media link with an address as the message
This PR, #6444 also touched the |
b711734
to
28b7289
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit (cc @bitpshr)
This pull request adds goerli network support.
Resolves #6249