Fixes display of token amount on the confirm transaction screen #6763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
approved these changes
Jun 28, 2019
tmashuang
approved these changes
Jun 28, 2019
Merged
whymarrh
approved these changes
Jun 28, 2019
danfinlay
added a commit
that referenced
this pull request
Jul 1, 2019
Using admin privilege to bypass code owner review because it has already [been reviewed](#6763) and those code owners are out today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6762
As discovered by @Gudahtt, 748801f#diff-18388ebb04a4abd10f886dfe385e77d8L391 removed a call to
updateTokenProps, which would have set the correct decimals instate.confirmTransaction.tokenProps.tokenDecimals. Without that data in state, calculations of token amounts were accounting for the token's decimal values.This PR fixes that issue by retrieving the necessary data for correct rendering of token amounts on mount of the
confirm-transaction.componentand then setting it in state with the other token data. It discontinues use of theconfirmTransaction.tokenPropsfor token transaction confirm screen rendering. Necessary values are now calculated withinconfirm-token-transaction-base.component. This aligns with our eventual desire to discontinue use of that part of state altogether.The first commit of this PR adds an e2e test that currently fails on develop and passes with the fixes of this PR.