Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Copy Tx ID and block explorer link for transactions without hash #6928

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Disable Copy Tx ID and block explorer link for transactions without hash #6928

merged 1 commit into from
Jul 30, 2019

Conversation

whymarrh
Copy link
Contributor

This PR disables the buttons on a tx list item when the tx hash is missing.

Before & after:

@whymarrh whymarrh requested review from Gudahtt and danjm July 29, 2019 12:41
Gudahtt
Gudahtt approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@whymarrh whymarrh merged commit 2761cc5 into MetaMask:develop Jul 30, 2019
@whymarrh whymarrh deleted the hide-tx-id-btns branch July 30, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whymarrh @Gudahtt