Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mobile sync #6967

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Update mobile sync #6967

merged 2 commits into from
Aug 6, 2019

Conversation

brunobar79
Copy link
Contributor

This PR is related to MetaMask/metamask-mobile#989

  • Updated the pubnub dep to match mobile
  • Use exact match version for the pubnub dep so we're always in the same version on both sides.
  • Updated the listener removal code to work with the latest pubnub SDK code.

@brunobar79 brunobar79 requested a review from Gudahtt as a code owner August 6, 2019 18:52
@metamaskbot
Copy link
Collaborator

Builds ready [e23b65a]: chrome, firefox, edge, opera

whymarrh
whymarrh approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunobar79 brunobar79 merged commit 835d4fb into develop Aug 6, 2019
@brunobar79 brunobar79 deleted the fix-mobile-sync branch August 6, 2019 19:33
Gudahtt added a commit that referenced this pull request Aug 6, 2019
@Gudahtt
Merge remote-tracking branch 'origin/develop' into Version-v7.0.0
232600d 
* origin/develop:
  Update mobile sync (#6967)
Gudahtt added a commit that referenced this pull request Aug 6, 2019
@Gudahtt
Add #6967 to changelog
372241e
@whymarrh whymarrh mentioned this pull request Aug 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

@estebanmino estebanmino Awaiting requested review from estebanmino

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunobar79 @metamaskbot @whymarrh