Remove blockscale, replace with ethgasstation #7059
Conversation
Yes, since I changed the values of what our average and fast are in relation to the response. If it was just changing the url, I wouldn't have needed to change it. |
| { | ||
| 'headers': {}, | ||
| 'referrer': 'https://dev.blockscale.net/api/', | ||
| 'referrer': 'http://ethgasstation.info/json/', |
There was a problem hiding this comment.
I'm curious to know why http is used here instead of https. I noticed other fetches to ethgasstation set this referrer as well.
There was a problem hiding this comment.
Looks good!
The change from slow/fast/faster to slow/average/fast seems like a good idea. I went looking briefly for an indication of why fast/faster were used in the first place, but couldn't find any. I guess it may have been a mistake.
I did notice that the dev.blockscale.net URLs were still in the e2e and integration tests - seemingly only used in the fetch mocks. Each of those cases should be deleted, since we're not using blockscale anymore.
These fetch mocks have been unnecessary since #7059
These fetch mocks have been unnecessary since #7059
Remove blockscale, replace with ethgasstation for gas estimation. Also, use safelow, average, and fast values instead of safelow, fast, fastest.
Closes #7040
Closes #7024