Allow dismissing privacy mode from popup #7093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The privacy mode notification was not able to be dismissed from the popup UI. It should have been dismissed after clicking "Learn more", but that button opens a new tab first before dismissing the flag. Opening the new tab kills the pop UI process before it has a chance to set that flag, so it never gets set. Re-ordering the handler to set the flag first avoids this problem.
Gudahtt
force-pushed
the
allow-dismissing-privacy-mode-from-popup
branch
from
1461c69 to
3a4b3f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The privacy mode notification was not able to be dismissed from the popup UI. It should have been dismissed after clicking "Learn more", but that button opens a new tab first before dismissing the flag. Opening the new tab kills the pop UI process before it has a chance to set that flag, so it never gets set.
Re-ordering the handler to set the flag first avoids this problem.
A separate dismiss button has also been added to the notification.