Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build - dont create bundler until task is actually run #7117

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Sep 6, 2019

we were creating the bundler (browserify instance) at task definition time, so it was being instantiated even if it was never used.

@metamaskbot
Copy link
Collaborator

Builds ready [df8eea9]: chrome, firefox, edge, opera

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@Gudahtt Gudahtt merged commit 0dad4db into develop Sep 9, 2019
@whymarrh whymarrh deleted the build-perf-fix branch November 19, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants