Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix advanced tab gas chart #7380

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Fix advanced tab gas chart #7380

merged 1 commit into from
Nov 11, 2019

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 10, 2019

The gas chart on the advanced tab was not converting the gas price selected into hex before setting it in state, resulting in the UI throwing errors and the price being set incorrectly. It now converts in the same manner as the input fields.

The gas chart on the advanced tab was not converting the gas price
selected into hex before setting it in state, resulting in the UI
throwing errors and the price being set incorrectly. It now converts
in the same manner as the input fields.
@metamaskbot
Copy link
Collaborator

Builds ready [ed87b27]

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good fix, thanks!

@Gudahtt Gudahtt merged commit a8175eb into develop Nov 11, 2019
@whymarrh whymarrh deleted the fix-advanced-tab-gas-chart branch November 12, 2019 17:57
@Gudahtt Gudahtt mentioned this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants