Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable no-var rule for ESLint #7590

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Conversation

whymarrh
Copy link
Contributor

This PR enables the no-var ESLint rule. const or let should be used instead.

The --fix option on the command line can automatically fix some of the problems reported by this rule.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit e61745a into MetaMask:develop Dec 3, 2019
@whymarrh whymarrh deleted the eslint-no-var branch December 3, 2019 14:52
Gudahtt pushed a commit that referenced this pull request Dec 3, 2019
* eslint: Enable no-var rule
* yarn lint --fix
Gudahtt added a commit that referenced this pull request Dec 3, 2019
* origin/develop:
  Fix SimpleDropdown event bubbling (#7627)
  Remove unneeded store connections (#7625)
  Replace wild random number key with index (#7629)
  Use ES6 exports for selectors (#7626)
  Fix a typo made comparing previous prop (#7628)
  Connect distinct accounts per site (#7004)
  eslint: Enable more react/jsx-* rules (#7592)
  Enable react/no-unused-state rule for ESLint (#7609)
  Enable no-var rule for ESLint (#7590)
  Process URL fragment for ens-ipfs redirects (#7604)
  add locale fix script (#7580)
  Prevent redux state mutation (#7598)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants