Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary shouldComponentUpdate #7875

Merged
merged 1 commit into from
Jan 21, 2020

Commits on Jan 21, 2020

  1. Remove unnecessary shouldComponentUpdate

    The `confirm-seed-phrase` component extends PureComponent, so it
    doesn't need a `shouldComponentUpdate` function. The state is
    effectively immutable, as all state is either a primitive type or is
    updated with new instances rather than mutation.
    
    Removing this function will silence a warning message printed to the
    console during e2e tests (React doesn't want you to set this function
    on `PureComponent`s).
    
    Removing this function also exposed an unused piece of state, which has
    also been removed.
    Gudahtt committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    52e51ce View commit details
    Browse the repository at this point in the history