Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Snapshot txMeta without cloning history (#8363)" #8458

Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 29, 2020

Backport #8363 to v7.7.9. Note that this uses clone instead of cloneDeep, because clone hadn't yet been replaced by cloneDeep on master.

Backporting that change as well would have been very disruptive, so I've updated this to use clone instead to minimize conflicts. It is functionally equivalent.

@Gudahtt Gudahtt force-pushed the backport-snapshot-tx-meta-without-cloning-history branch from f0ae6ef to c59fd71 Compare April 29, 2020 15:51
@metamaskbot
Copy link
Collaborator

Builds ready [c59fd71]

@Gudahtt Gudahtt marked this pull request as ready for review April 29, 2020 17:35
whymarrh
whymarrh previously approved these changes Apr 29, 2020
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Backport #8363 to v7.7.9. Note that this uses `clone` instead of
`cloneDeep`, because `clone` hadn't yet been replaced by `cloneDeep` on
`master`.

Backporting that change as well would have been very disruptive, so
I've updated this to use `clone` instead to minimize conflicts. It is
functionally equivalent.
@Gudahtt Gudahtt force-pushed the backport-snapshot-tx-meta-without-cloning-history branch from c59fd71 to fea5106 Compare April 29, 2020 18:21
@metamaskbot
Copy link
Collaborator

Builds ready [fea5106]

@Gudahtt Gudahtt merged commit f91bd3a into Version-v7.7.9 Apr 29, 2020
@Gudahtt Gudahtt deleted the backport-snapshot-tx-meta-without-cloning-history branch April 29, 2020 19:17
@metamaskbot metamaskbot mentioned this pull request May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants