Support reverse ens names in tx detail (#969)

* reverse ens names in tx history * update snapshots
MetaMask · Jul 30, 2019 · 0c62975 · 0c62975
1 parent bc6be5d
commit 0c62975
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 16 deletions.
diff --git a/app/components/UI/TransactionElement/TransactionDetails/__snapshots__/index.test.js.snap b/app/components/UI/TransactionElement/TransactionDetails/__snapshots__/index.test.js.snap
@@ -206,8 +206,8 @@ exports[`TransactionDetails should render correctly 1`] = `
       ]
     }
   >
-    <Text
-      numberOfLines={1}
+    <Connect(EthereumAddress)
+      address="0x0"
       style={
         Object {
           "color": "#777777",
@@ -217,9 +217,7 @@ exports[`TransactionDetails should render correctly 1`] = `
           "fontWeight": "400",
         }
       }
-    >
-      0x0
-    </Text>
+    />
     <TouchableOpacity
       activeOpacity={0.2}
       onPress={[Function]}
@@ -273,8 +271,8 @@ exports[`TransactionDetails should render correctly 1`] = `
       ]
     }
   >
-    <Text
-      numberOfLines={1}
+    <Connect(EthereumAddress)
+      address="0x1"
       style={
         Object {
           "color": "#777777",
@@ -284,9 +282,7 @@ exports[`TransactionDetails should render correctly 1`] = `
           "fontWeight": "400",
         }
       }
-    >
-      0x1
-    </Text>
+    />
     <TouchableOpacity
       activeOpacity={0.2}
       onPress={[Function]}

diff --git a/app/components/UI/TransactionElement/TransactionDetails/index.js b/app/components/UI/TransactionElement/TransactionDetails/index.js
@@ -15,6 +15,7 @@ import Logger from '../../../../util/Logger';
 import { connect } from 'react-redux';
 import URL from 'url-parse';
 import DeviceSize from '../../../../util/DeviceSize';
+import EthereumAddress from '../../EthereumAddress';
 
 const HASH_LENGTH = DeviceSize.isSmallDevice() ? 18 : 20;
 
@@ -341,16 +342,12 @@ class TransactionDetails extends PureComponent {
 				{this.renderTxHash(this.props.transactionDetails.transactionHash)}
 				<Text style={styles.detailRowTitle}>{strings('transactions.from')}</Text>
 				<View style={[styles.detailRowInfo, styles.singleRow]}>
-					<Text style={styles.detailRowText} numberOfLines={1}>
-						{this.props.transactionDetails.renderFrom}
-					</Text>
+					<EthereumAddress style={styles.detailRowText} address={this.props.transactionDetails.renderFrom} />
 					{this.renderCopyFromIcon()}
 				</View>
 				<Text style={styles.detailRowTitle}>{strings('transactions.to')}</Text>
 				<View style={[styles.detailRowInfo, styles.singleRow]}>
-					<Text style={styles.detailRowText} numberOfLines={1}>
-						{this.props.transactionDetails.renderTo}
-					</Text>
+					<EthereumAddress style={styles.detailRowText} address={this.props.transactionDetails.renderTo} />
 					{this.renderCopyToIcon()}
 				</View>
 				<Text style={styles.detailRowTitle}>{strings('transactions.details')}</Text>