Fix/disable iframes support for now (#1881)

* disable iframes for now * Disable sending messages to iframes for now
MetaMask · Oct 15, 2020 · f3c9e96 · f3c9e96
1 parent 1b8cead
commit f3c9e96
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/app/components/Views/BrowserTab/index.js b/app/components/Views/BrowserTab/index.js
@@ -689,9 +689,12 @@ export const BrowserTab = props => {
 		backgroundBridges.current.push(newBridge);
 	};
 
+	/**
+	 * Disabling iframes for now
 	const onFrameLoadStarted = url => {
 		url && initializeBackgroundBridge(url, false);
 	};
+	*/
 
 	/**
 	 * Is the current tab the active tab
@@ -1285,11 +1288,13 @@ export const BrowserTab = props => {
 			}
 
 			switch (data.type) {
+				/**
+				* Disabling iframes for now
 				case 'FRAME_READY': {
 					const { url } = data.payload;
 					onFrameLoadStarted(url);
 					break;
-				}
+				}*/
 				case 'GET_WEBVIEW_URL':
 					webviewUrlPostMessagePromiseResolve.current &&
 						webviewUrlPostMessagePromiseResolve.current(data.payload);

diff --git a/app/util/browserScripts.js b/app/util/browserScripts.js
@@ -115,7 +115,10 @@ export const JS_POST_MESSAGE_TO_PROVIDER = (message, origin) => `(function () {
 	}
 })()`;
 
-export const JS_IFRAME_POST_MESSAGE_TO_PROVIDER = (message, origin) => `(function () {
+export const JS_IFRAME_POST_MESSAGE_TO_PROVIDER = (message, origin) => `(function () {})()`;
+/** Disable sending messages to iframes for now
+ *
+`(function () {
 	const iframes = document.getElementsByTagName('iframe');
 	for (let frame of iframes){
 
@@ -127,3 +130,4 @@ export const JS_IFRAME_POST_MESSAGE_TO_PROVIDER = (message, origin) => `(functio
 
 	}
 })()`;
+ */