Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapp not working #1269

Closed
brunobar79 opened this issue Jan 9, 2020 · 8 comments
Closed

Dapp not working #1269

brunobar79 opened this issue Jan 9, 2020 · 8 comments
Labels
dapp-compatibility type-bug Something isn't working

Comments

@brunobar79
Copy link
Contributor

From support ticket: http://gopherswild.com/vpp/

@brunobar79 brunobar79 added type-bug Something isn't working dapp-compatibility labels Jan 9, 2020
@woodydeck
Copy link

woodydeck commented Jan 10, 2020

This is my highly centralized application. If it is not available it means I am working on it, or sleeping and the server crashed. I would have bitched directly here had I known there was a mobile project branch that was public.

Please note that I believe that there is a huge project disconnect currently where developers like me can get their information on MetaMask. Gitter isn't monitored, and I blew my top there as well as to support email. I'm very frustrated because I feel like this whole disconnect I'm experiencing is a major problem with crypto and decentralization in general.

I also asked this related issue core to the functionality of MetaMask in dapps, but nobody officially answered:
https://ethereum.stackexchange.com/questions/78660/how-can-you-find-the-ethereum-provider-on-web3-browsers-other-than-metamask

I blame the Web3.js project as well. They have created three incompatible versions when there only need to be two, and then everyone downstream can't agree on how to implement things. I have no idea anymore what is 0.2, 1.2, or 2.0. I just want my users to be able to sign a message on mobile and on the desktop with an address (account) that is secured by a multi-billion dollar blockchain.

@rdymac
Copy link

rdymac commented Jan 30, 2020

On Mobile this dapp/website: dice2.win , is supposed to ask the user for approval, but instead it goes directly to rejected without showing the user any MetaMask prompt.

Case: 29772

dice2win

@woodydeck
Copy link

I have given up the fight, and have returned to centralized projects. I am very disappointed this was not prioritized. My project is not viable without a working web3 wallet on mobile. I am still available for help, but I can't guarantee my test server will stay live.

Funnily enough, I got things to work with Tron. All of the core Ethereum devs like to take shots at Tron, but fact is that they are currently more advanced than Ethereum's primary chain.

After the last 24 hours and seeing the Iowa Caucuses turn into a shitshow it is clear how important blockchain is in conjunction with centralized ad hoc services. Results can be public, and authentication can be much more secure than the passwords they emailed (!) to precinct managers.

@rekmarks
Copy link
Member

rekmarks commented Feb 11, 2020

@woodydeck I apologize it has taken us so long to get back to you. We are a small team, and unfortunately have triage based on project size.

Your dapp seems to be working in our mobile app now, using the latest develop. It will be in our next beta release.

I think that you are handling the accountsChanged event incorrectly, but I was able to log in and hit Deal just now. I'm not sure how it's supposed to work, so I can't be sure. See image below.

I'm happy to help if you have further questions! Otherwise I will close this issue in one week from today.

image

@rekmarks
Copy link
Member

@rdymac I just went to dice2.win on latest develop and it asked me to connect. We've updated the provider so it may be due to that.

@woodydeck
Copy link

woodydeck commented Feb 12, 2020

I apologize it has taken us so long to get back to you. We are a small team, and unfortunately have triage based on project size.

This issue should be #1. People actually were interested in vesting hundreds of thousands to develop similar games until I advised of the bottleneck. They won't be back for many years to explore this now unfortunately and I have moved on to mundane centralized stuff again.

I also think evangelists should be promoting this centralized approach as a stop gap so we get adoption. The blockchain is slow, expensive, bloated, and Web3 is a mess now. MetaMask doesn't have to be a mess as long as this flow is unimpacted.

I think that you are handling the accountsChanged event incorrectly, but I was able to log in and hit Deal just now. I'm not sure how it's supposed to work, so I can't be sure. See image below.

It's copy pasta from the docs besides what Phaser does when it happens. I'm curious, what exactly do you mean?

The program has to log you out when you change accounts because the websocket authentication decodes a JWT that has an address embedded. You could issue a new token with the new address if this happens, but this raises security issues with spoofing, so it's best to just have them take two clicks to sign another nonce. Also, gaming regulations can require affirmative consent, and login logs, though that wasn't the primary reason.

If you want the source code, I can send to you privately.

I'm happy to help if you have further questions! Otherwise I will close this issue in one week from today.

I will check on mobile and report back. Obviously it doesn't look great that way. I haven't been able to test fullscreen workarounds since it hasn't worked on mobile, and I'm too lazy to adjust everything for a test version. It would take me a day. Going fullscreen on HTML5 is a major annoyance.

@rdymac
Copy link

rdymac commented Feb 21, 2020

@rdymac I just went to dice2.win on latest develop and it asked me to connect. We've updated the provider so it may be due to that.

So it should work once develop has been merged to master and a new version is published, right?


New report of a dapp not working on MetaMask Mobile for Android. Case number: 31236

Mobile Browser not executing get calls
Our DApp, Cryptomibs, has been working fine with your mobile [app] up until a few days ago. Now your [mobile app] is not executing get calls form DApp. We have no issues with regular mobile browsers. We really need your help to get this resolved. Thank you.

@woodydeck
Copy link

It doesn't work yet on the test flight version v0.2.13 build 356.

I was spending some time getting orientation hack to work by sniffing user agents. I am not sure if there is a separate issue for that. The lack of orientation is a bummer for games.

salimtb added a commit that referenced this issue Jan 25, 2024
## **Description**
the goal of this PR is to add translation for the feature add privacy
toggle

Fixes: [#1269](MetaMask/mobile-planning#1269)

## **Manual testing steps**

1. the locals will be used in another PR , this commit will be
cherry-picked

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
chrisleewilcox pushed a commit that referenced this issue Feb 6, 2024
## **Description**

This task aims to add the ability to turn on and off the network
verification feature. To do that, we will be adding both a toggleable
section in the settings as well as a contextual banner and sheet for
quickly toggling it on.

## **Related issues**

Fixes: [#1269](MetaMask/mobile-planning#1269)

## **Manual testing steps**

1. Go to the setting page
2. Go to Security and Privacy
3. Enable/disable the network details check
4. Go to add network
5. if the toggle was disabled you should see a banner ( check the video
below )

## **Screenshots/Recordings**


### **Before**

### **After**


https://drive.google.com/drive/folders/1BeTFKHelGrzu5XPUfXLTa-om7inhtowU?usp=drive_link

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapp-compatibility type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants