iOS Crash after editing gas price that dapp suggested #1473
Comments
|
@danfinlay Now it makes sense! I stumbled upon this bug while implementing the new design for advanced gas controls. If the gas price is |
|
another user reported the same to support: 36508 |
|
#1512 to the rescueeeee |
EtDu
added a commit
that referenced
this issue
Jun 9, 2020
* Locales: change Transaction fee to Network fee per design * Confirm: Use TransactionReviewFeeCard, add primaryCurrency prop, add ETH transaction fee, move renderIfGasEstimationReady to TransactionReviewFeeCard, remove adjust transaction fee button, pass props to TransactionReviewFeeCard * Create new TransactionReviewFeeCard component * TransactionReviewFeeCard: fix proptypes, create snapshot test, update other snapshots * Confirm: use slide up modal for custom gas * Confirm: Remove CustomGas style wrappers into CustomGas component, make CustomGas the only child of Modal * Locales: edit network fee, basic, save, cost explanation reword * CustomGas: Implement redesign. Still need to modify styling of individual gas selectors * CustomGas: fix gas selector styling * snapshot update * Approve: Use Modal in place of Action Modal, use updated CustomGas * Confirm: add gasError prop to CustomGas * CustomGas: disable save button if gas error * CustomGas: Implement advanced options design * update snapshot * CustomGas: fix padding on non iphoneX devices * Confirm: remove unused TransactionSummary * CustomGas: remove double logic and empty styles * Confirm: fix, change props.transactionState to state.transaction (merge conflict recovery) * snapshot update * SendFlow/CustomGas: fix button not disabling and error not showing when updating gas limit * SendFlow/CustomGas: Fix #1473 crash when modifying gas limit if gas price is empty * Confirm: add styles for ActionModal, use ActionModal * SendFlow/CustomGas: modify styles, remove footer container * ActionModal: add props * ActionContent: add props * Confirm + CutomGas: add ready state, pass down prop to change it, change it when CustomGas is ready so the button can be disabled * Approve: add in ActionModal styles, use ActionModal * snapshot update * SendFlow/CustomGas: QA fix save not disabled on certain case Co-authored-by: Ibrahim Taveras <ibrahimtaveras00@gmail.com>
|
This issue still seems to be occurring even on current develop/ 0.2.17 version Seen here = https://recordit.co/XCdB1XkMo2 steps to reproduce:
cc @omnat |
|
This is fixed |
rickycodes
pushed a commit
that referenced
this issue
Jan 31, 2022
* Locales: change Transaction fee to Network fee per design * Confirm: Use TransactionReviewFeeCard, add primaryCurrency prop, add ETH transaction fee, move renderIfGasEstimationReady to TransactionReviewFeeCard, remove adjust transaction fee button, pass props to TransactionReviewFeeCard * Create new TransactionReviewFeeCard component * TransactionReviewFeeCard: fix proptypes, create snapshot test, update other snapshots * Confirm: use slide up modal for custom gas * Confirm: Remove CustomGas style wrappers into CustomGas component, make CustomGas the only child of Modal * Locales: edit network fee, basic, save, cost explanation reword * CustomGas: Implement redesign. Still need to modify styling of individual gas selectors * CustomGas: fix gas selector styling * snapshot update * Approve: Use Modal in place of Action Modal, use updated CustomGas * Confirm: add gasError prop to CustomGas * CustomGas: disable save button if gas error * CustomGas: Implement advanced options design * update snapshot * CustomGas: fix padding on non iphoneX devices * Confirm: remove unused TransactionSummary * CustomGas: remove double logic and empty styles * Confirm: fix, change props.transactionState to state.transaction (merge conflict recovery) * snapshot update * SendFlow/CustomGas: fix button not disabling and error not showing when updating gas limit * SendFlow/CustomGas: Fix #1473 crash when modifying gas limit if gas price is empty * Confirm: add styles for ActionModal, use ActionModal * SendFlow/CustomGas: modify styles, remove footer container * ActionModal: add props * ActionContent: add props * Confirm + CutomGas: add ready state, pass down prop to change it, change it when CustomGas is ready so the button can be disabled * Approve: add in ActionModal styles, use ActionModal * snapshot update * SendFlow/CustomGas: QA fix save not disabled on certain case Co-authored-by: Ibrahim Taveras <ibrahimtaveras00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DeFiDad reported
Using hegic.co
It seems to suggest a gas price to metamask.
When the user then opens advanced gas controls and tries to edit the gas price, MetaMask crashes.
The text was updated successfully, but these errors were encountered: