Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete redesigns for approval flow #1503

Closed
danjm opened this issue Apr 21, 2020 · 0 comments · Fixed by #1558
Closed

Complete redesigns for approval flow #1503

danjm opened this issue Apr 21, 2020 · 0 comments · Fixed by #1558
Assignees
@rickycodes

Comments

@danjm
Copy link
Contributor

danjm commented Apr 21, 2020 •
edited by cjeria
Loading

The task is to make the confirmation flow for token approvals match the new designs. The main screen looks like:

image

The rest of the design can be seen here: https://www.figma.com/file/dzapXt5s0pKBxb9lZkIoDM/%231352---Confirm-transactions?node-id=916%3A29

Most of the components needed should already have been created when resolving #1484, #1497, #1499, #1500

You will also have to modify the edit permission modal to follow the new style:
Screenshot from 2020-04-21 07-16-27

Leave the "Request details" modal to the end, as it may change or be removed as a result of user testing:

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickycodes rickycodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete redesigns for approval flow MetaMask/metamask-mobile
2 participants
@rickycodes @danjm