Create transaction data modal #1499
Assignees
Labels
release-7.20.0
Issue or pull request that will be included in release 7.20.0
Comments
This was referenced Apr 20, 2020
4 tasks
Cal-L
added a commit
that referenced
this issue
Mar 23, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR simplifies SDK initialization logic, which was causing the security modal to re-render, which was breaking both performance and E2E tests Fixes #1499 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://recordit.co/NcG1KbKuxH ### **After** <!-- [screenshots/recordings] --> https://github.com/MetaMask/metamask-mobile/assets/10508597/c50bd819-71e5-42b1-8236-4fe0acb41547 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-7.20.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The task is to create the new data modal being used across the latest confirmation designs:
For now, this can be implemented to replace the data section of the Approve screens:
(Code for that screen:
metamask-mobile/app/components/Views/ApproveView/Approve/index.js)Designs: https://www.figma.com/file/dzapXt5s0pKBxb9lZkIoDM/%231352---Confirm-transactions?node-id=916%3A101
The text was updated successfully, but these errors were encountered: