Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting token doesn't respect network #2557

Closed
ibrahimtaveras00 opened this issue Apr 20, 2021 · 4 comments · Fixed by #3650
Closed

Requesting token doesn't respect network #2557

ibrahimtaveras00 opened this issue Apr 20, 2021 · 4 comments · Fixed by #3650
Assignees
Labels
type-bug Something isn't working

Comments

@ibrahimtaveras00
Copy link
Contributor

ibrahimtaveras00 commented Apr 20, 2021

Describe the bug

When using the request flow, or tapping on a deeplink, we are only respecting the request's network if it's coming from a custom network, but we're not respecting Mainnet nor other default networks

Screenshots

In this example, I'm requesting ETH while on mainnet, but upon scanning the QR code, the network isn't being switched to Mainnet; seen here = http://recordit.co/sIUhBU0CMk

To Reproduce
Steps to reproduce the behavior

  1. Create a deeplink in browser or QR code payment request from one network
  2. With your device, open app and be on a different network than above request
  3. Scan QR code, or open deeplink from browser

Feel free to use this deeplink which should change network to Rinkeby:

https://metamask.app.link/send/0x1FDb169Ef12954F20A15852980e1F0C122BfC1D6@4?value=1e15

Or scan this payment request QR code:

Screen Shot 2021-04-20 at 6 48 35 PM

Expected behavior

My network should automatically change according to the network of the payment request


to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@ibrahimtaveras00 ibrahimtaveras00 added the type-bug Something isn't working label Apr 20, 2021
@ibrahimtaveras00
Copy link
Contributor Author

This shows how it currently works only on custom networks

In this example I'm on mainnet, scan a request from xDAI chain and it properly changes my network

seen here = http://recordit.co/5ArBvHTIlb

@rahul-kothari
Copy link

Any updates on this?

@sethkfman
Copy link
Contributor

Example deep links can be found here: https://www.notion.so/DeepLink-Test-e9b159d196424926809848705ffa015f

@sethkfman sethkfman changed the title Requesting token doesn't respect network [Fatia] Requesting token doesn't respect network Jan 5, 2022
@Fatxx Fatxx removed their assignment Jan 19, 2022
@Fatxx
Copy link
Contributor

Fatxx commented Jan 19, 2022

Fixed at #3650

@Fatxx Fatxx changed the title [Fatia] Requesting token doesn't respect network Requesting token doesn't respect network Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
None yet
4 participants