-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle network changes for incoming deeplink and qr code requests. #3650
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fatxx sending this back your way. Below are the list of issues I found:
Issue 1
If I attempt to deep link to a custom network (such as matic or binance) and that network is not added to my wallet I get conflicting behavior. I see the same clipboard alert message when my network is successfully changed and in that message I also see “oops something went wrong please try again”
to reproduce:
ensure you do not have matic added to your list of networks
deep link here
notice the behavior.
Issue 1B
If i were to:
switch to a custom network. In this case i am using binance.
create a request qr-code/deep link by going through the request flow in the app on device A,
On device B i do not have binance (BSC) added to my wallet
scan the QR on device B
on device B once the QR takes you to the send flow, the network work defaults to your current wallet. Shouldn’t we let the user know that they do not have the network(in this case binance) added?
see here
Potential Issue 2 There is a bug with the clipboard alert whenever a network changes from a custom network back to main net. Unfortunately I am unable to provide a screenshot/recording because this happens sporadically. |
@cortisiko you can QA if you like, although it needs another dev review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🌮 🌮
@Fatxx did you want my input on copy on this issue? I don't see a suggestion. Am I at the wrong issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
When a user receives an incoming request either by deeplink or QR code scan, and he doesn't have the requested network selected it should now automatically switch to the requested network or shows up an alert if the network isn't available in user preferred networks list.
To Reproduce
Steps to reproduce the behavior
Create a deeplink in browser or QR code payment request from one network
With your device, open app and be on a different network than above request
Scan QR code, or open deeplink from browser
Feel free to use this deeplink which should change network to Rinkeby:
https://metamask.app.link/send/0x1FDb169Ef12954F20A15852980e1F0C122BfC1D6@4?value=1e15
Checklist
Issue
Resolves #2557 and #2836