Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token detection for Ethereum Mainnet #3140

Closed
5 tasks done
Cal-L opened this issue Sep 16, 2021 · 0 comments
Closed
5 tasks done

Token detection for Ethereum Mainnet #3140

Cal-L opened this issue Sep 16, 2021 · 0 comments
Assignees

Comments

@Cal-L
Copy link
Contributor

Cal-L commented Sep 16, 2021

Description

This is a continuation on MVP for auto token detection. For now, we're scoping down token detection to only work for Ethereum Mainnet. The token detection toggle in Experimental settings should hide for testnets + custom networks.

Technical Details

  • Hide the token detection toggle for anything other than Ethereum Mainnet.
  • Turn off toggle by default
  • Move toggle over to Experimental
  • For Ethereum Mainnet in token search, add token detection info banner as header
  • Add analytics events for toggling token detection toggle. Token detection turned ON & Token detection turned OFF. Provide chainId property.

Acceptance Criteria

  • Token detection toggle should be hidden for all networks other than Ethereum Mainnet.
  • Tokens should be auto detected on Ethereum Mainnet, when token detection is on (user opts in).
  • Token search in Add Tokens should return dynamic list from API if token detection is on. Otherwise, returns static list of tokens.
  • Test analytics events for token detection toggle on & off

References

@Cal-L Cal-L self-assigned this Sep 16, 2021
@Cal-L Cal-L closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant